# Copyright 2013-2022 Lawrence Livermore National Security, LLC and other
# Spack Project Developers. See the top-level COPYRIGHT file for details.
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
"""These version tests were taken from the RPM source code.
We try to maintain compatibility with RPM's version semantics
where it makes sense.
"""
import os
import sys
import pytest
from llnl.util.filesystem import working_dir
import spack.package
import spack.spec
from spack.util.executable import which
from spack.version import Version, VersionList, VersionRange, ver
[docs]def assert_ver_lt(a, b):
"""Asserts the results of comparisons when 'a' is less than 'b'."""
a, b = ver(a), ver(b)
assert a < b
assert a <= b
assert a != b
assert not a == b
assert not a > b
assert not a >= b
[docs]def assert_ver_gt(a, b):
"""Asserts the results of comparisons when 'a' is greater than 'b'."""
a, b = ver(a), ver(b)
assert a > b
assert a >= b
assert a != b
assert not a == b
assert not a < b
assert not a <= b
[docs]def assert_ver_eq(a, b):
"""Asserts the results of comparisons when 'a' is equal to 'b'."""
a, b = ver(a), ver(b)
assert not a > b
assert a >= b
assert not a != b
assert a == b
assert not a < b
assert a <= b
[docs]def assert_in(needle, haystack):
"""Asserts that 'needle' is in 'haystack'."""
assert ver(needle) in ver(haystack)
[docs]def assert_not_in(needle, haystack):
"""Asserts that 'needle' is not in 'haystack'."""
assert ver(needle) not in ver(haystack)
[docs]def assert_canonical(canonical_list, version_list):
"""Asserts that a redundant list is reduced to canonical form."""
assert ver(canonical_list) == ver(version_list)
[docs]def assert_overlaps(v1, v2):
"""Asserts that two version ranges overlaps."""
assert ver(v1).overlaps(ver(v2))
[docs]def assert_no_overlap(v1, v2):
"""Asserts that two version ranges do not overlap."""
assert not ver(v1).overlaps(ver(v2))
[docs]def assert_satisfies(v1, v2):
"""Asserts that 'v1' satisfies 'v2'."""
assert ver(v1).satisfies(ver(v2))
[docs]def assert_does_not_satisfy(v1, v2):
"""Asserts that 'v1' does not satisfy 'v2'."""
assert not ver(v1).satisfies(ver(v2))
[docs]def check_intersection(expected, a, b):
"""Asserts that 'a' intersect 'b' == 'expected'."""
assert ver(expected) == ver(a).intersection(ver(b))
[docs]def check_union(expected, a, b):
"""Asserts that 'a' union 'b' == 'expected'."""
assert ver(expected) == ver(a).union(ver(b))
[docs]def test_string_prefix():
assert_ver_eq('xsdk-0.2.0', 'xsdk-0.2.0')
assert_ver_lt('xsdk-0.2.0', 'xsdk-0.3')
assert_ver_gt('xsdk-0.3', 'xsdk-0.2.0')
[docs]def test_two_segments():
assert_ver_eq('1.0', '1.0')
assert_ver_lt('1.0', '2.0')
assert_ver_gt('2.0', '1.0')
[docs]def test_develop():
assert_ver_eq('develop', 'develop')
assert_ver_eq('develop.local', 'develop.local')
assert_ver_lt('1.0', 'develop')
assert_ver_gt('develop', '1.0')
assert_ver_eq('1.develop', '1.develop')
assert_ver_lt('1.1', '1.develop')
assert_ver_gt('1.develop', '1.0')
assert_ver_gt('0.5.develop', '0.5')
assert_ver_lt('0.5', '0.5.develop')
assert_ver_lt('1.develop', '2.1')
assert_ver_gt('2.1', '1.develop')
assert_ver_lt('1.develop.1', '1.develop.2')
assert_ver_gt('1.develop.2', '1.develop.1')
assert_ver_lt('develop.1', 'develop.2')
assert_ver_gt('develop.2', 'develop.1')
# other +infinity versions
assert_ver_gt('master', '9.0')
assert_ver_gt('head', '9.0')
assert_ver_gt('trunk', '9.0')
assert_ver_gt('develop', '9.0')
# hierarchical develop-like versions
assert_ver_gt('develop', 'master')
assert_ver_gt('master', 'head')
assert_ver_gt('head', 'trunk')
assert_ver_gt('9.0', 'system')
# not develop
assert_ver_lt('mydevelopmentnightmare', '1.1')
assert_ver_lt('1.mydevelopmentnightmare', '1.1')
assert_ver_gt('1.1', '1.mydevelopmentnightmare')
[docs]def test_isdevelop():
assert ver('develop').isdevelop()
assert ver('develop.1').isdevelop()
assert ver('develop.local').isdevelop()
assert ver('master').isdevelop()
assert ver('head').isdevelop()
assert ver('trunk').isdevelop()
assert ver('1.develop').isdevelop()
assert ver('1.develop.2').isdevelop()
assert not ver('1.1').isdevelop()
assert not ver('1.mydevelopmentnightmare.3').isdevelop()
assert not ver('mydevelopmentnightmare.3').isdevelop()
[docs]def test_three_segments():
assert_ver_eq('2.0.1', '2.0.1')
assert_ver_lt('2.0', '2.0.1')
assert_ver_gt('2.0.1', '2.0')
[docs]def test_alpha():
# TODO: not sure whether I like this. 2.0.1a is *usually*
# TODO: less than 2.0.1, but special-casing it makes version
# TODO: comparison complicated. See version.py
assert_ver_eq('2.0.1a', '2.0.1a')
assert_ver_gt('2.0.1a', '2.0.1')
assert_ver_lt('2.0.1', '2.0.1a')
[docs]def test_patch():
assert_ver_eq('5.5p1', '5.5p1')
assert_ver_lt('5.5p1', '5.5p2')
assert_ver_gt('5.5p2', '5.5p1')
assert_ver_eq('5.5p10', '5.5p10')
assert_ver_lt('5.5p1', '5.5p10')
assert_ver_gt('5.5p10', '5.5p1')
[docs]def test_num_alpha_with_no_separator():
assert_ver_lt('10xyz', '10.1xyz')
assert_ver_gt('10.1xyz', '10xyz')
assert_ver_eq('xyz10', 'xyz10')
assert_ver_lt('xyz10', 'xyz10.1')
assert_ver_gt('xyz10.1', 'xyz10')
[docs]def test_alpha_with_dots():
assert_ver_eq('xyz.4', 'xyz.4')
assert_ver_lt('xyz.4', '8')
assert_ver_gt('8', 'xyz.4')
assert_ver_lt('xyz.4', '2')
assert_ver_gt('2', 'xyz.4')
[docs]def test_nums_and_patch():
assert_ver_lt('5.5p2', '5.6p1')
assert_ver_gt('5.6p1', '5.5p2')
assert_ver_lt('5.6p1', '6.5p1')
assert_ver_gt('6.5p1', '5.6p1')
[docs]def test_rc_versions():
assert_ver_gt('6.0.rc1', '6.0')
assert_ver_lt('6.0', '6.0.rc1')
[docs]def test_alpha_beta():
assert_ver_gt('10b2', '10a1')
assert_ver_lt('10a2', '10b2')
[docs]def test_double_alpha():
assert_ver_eq('1.0aa', '1.0aa')
assert_ver_lt('1.0a', '1.0aa')
assert_ver_gt('1.0aa', '1.0a')
[docs]def test_padded_numbers():
assert_ver_eq('10.0001', '10.0001')
assert_ver_eq('10.0001', '10.1')
assert_ver_eq('10.1', '10.0001')
assert_ver_lt('10.0001', '10.0039')
assert_ver_gt('10.0039', '10.0001')
[docs]def test_close_numbers():
assert_ver_lt('4.999.9', '5.0')
assert_ver_gt('5.0', '4.999.9')
[docs]def test_date_stamps():
assert_ver_eq('20101121', '20101121')
assert_ver_lt('20101121', '20101122')
assert_ver_gt('20101122', '20101121')
[docs]def test_underscores():
assert_ver_eq('2_0', '2_0')
assert_ver_eq('2.0', '2_0')
assert_ver_eq('2_0', '2.0')
assert_ver_eq('2-0', '2_0')
assert_ver_eq('2_0', '2-0')
[docs]def test_rpm_oddities():
assert_ver_eq('1b.fc17', '1b.fc17')
assert_ver_lt('1b.fc17', '1.fc17')
assert_ver_gt('1.fc17', '1b.fc17')
assert_ver_eq('1g.fc17', '1g.fc17')
assert_ver_gt('1g.fc17', '1.fc17')
assert_ver_lt('1.fc17', '1g.fc17')
# Stuff below here is not taken from RPM's tests and is
# unique to spack
[docs]def test_version_ranges():
assert_ver_lt('1.2:1.4', '1.6')
assert_ver_gt('1.6', '1.2:1.4')
assert_ver_eq('1.2:1.4', '1.2:1.4')
assert ver('1.2:1.4') != ver('1.2:1.6')
assert_ver_lt('1.2:1.4', '1.5:1.6')
assert_ver_gt('1.5:1.6', '1.2:1.4')
[docs]def test_contains():
assert_in('1.3', '1.2:1.4')
assert_in('1.2.5', '1.2:1.4')
assert_in('1.3.5', '1.2:1.4')
assert_in('1.3.5-7', '1.2:1.4')
assert_not_in('1.1', '1.2:1.4')
assert_not_in('1.5', '1.2:1.4')
assert_not_in('1.5', '1.5.1:1.6')
assert_not_in('1.5', '1.5.1:')
assert_in('1.4.2', '1.2:1.4')
assert_not_in('1.4.2', '1.2:1.4.0')
assert_in('1.2.8', '1.2.7:1.4')
assert_in('1.2.7:1.4', ':')
assert_not_in('1.2.5', '1.2.7:1.4')
assert_in('1.4.1', '1.2.7:1.4')
assert_not_in('1.4.1', '1.2.7:1.4.0')
[docs]def test_in_list():
assert_in('1.2', ['1.5', '1.2', '1.3'])
assert_in('1.2.5', ['1.5', '1.2:1.3'])
assert_in('1.5', ['1.5', '1.2:1.3'])
assert_not_in('1.4', ['1.5', '1.2:1.3'])
assert_in('1.2.5:1.2.7', [':'])
assert_in('1.2.5:1.2.7', ['1.5', '1.2:1.3'])
assert_not_in('1.2.5:1.5', ['1.5', '1.2:1.3'])
assert_not_in('1.1:1.2.5', ['1.5', '1.2:1.3'])
[docs]def test_ranges_overlap():
assert_overlaps('1.2', '1.2')
assert_overlaps('1.2.1', '1.2.1')
assert_overlaps('1.2.1b', '1.2.1b')
assert_overlaps('1.2:1.7', '1.6:1.9')
assert_overlaps(':1.7', '1.6:1.9')
assert_overlaps(':1.7', ':1.9')
assert_overlaps(':1.7', '1.6:')
assert_overlaps('1.2:', '1.6:1.9')
assert_overlaps('1.2:', ':1.9')
assert_overlaps('1.2:', '1.6:')
assert_overlaps(':', ':')
assert_overlaps(':', '1.6:1.9')
assert_overlaps('1.6:1.9', ':')
[docs]def test_overlap_with_containment():
assert_in('1.6.5', '1.6')
assert_in('1.6.5', ':1.6')
assert_overlaps('1.6.5', ':1.6')
assert_overlaps(':1.6', '1.6.5')
assert_not_in(':1.6', '1.6.5')
assert_in('1.6.5', ':1.6')
[docs]def test_lists_overlap():
assert_overlaps('1.2b:1.7,5', '1.6:1.9,1')
assert_overlaps('1,2,3,4,5', '3,4,5,6,7')
assert_overlaps('1,2,3,4,5', '5,6,7')
assert_overlaps('1,2,3,4,5', '5:7')
assert_overlaps('1,2,3,4,5', '3, 6:7')
assert_overlaps('1, 2, 4, 6.5', '3, 6:7')
assert_overlaps('1, 2, 4, 6.5', ':, 5, 8')
assert_overlaps('1, 2, 4, 6.5', ':')
assert_no_overlap('1, 2, 4', '3, 6:7')
assert_no_overlap('1,2,3,4,5', '6,7')
assert_no_overlap('1,2,3,4,5', '6:7')
[docs]def test_canonicalize_list():
assert_canonical(['1.2', '1.3', '1.4'], ['1.2', '1.3', '1.3', '1.4'])
assert_canonical(['1.2', '1.3:1.4'], ['1.2', '1.3', '1.3:1.4'])
assert_canonical(['1.2', '1.3:1.4'], ['1.2', '1.3:1.4', '1.4'])
assert_canonical(['1.3:1.4'], ['1.3:1.4', '1.3', '1.3.1', '1.3.9', '1.4'])
assert_canonical(['1.3:1.4'], ['1.3', '1.3.1', '1.3.9', '1.4', '1.3:1.4'])
assert_canonical(
['1.3:1.5'], ['1.3', '1.3.1', '1.3.9', '1.4:1.5', '1.3:1.4']
)
assert_canonical(['1.3:1.5'], ['1.3, 1.3.1,1.3.9,1.4:1.5,1.3:1.4'])
assert_canonical(['1.3:1.5'], ['1.3, 1.3.1,1.3.9,1.4 : 1.5 , 1.3 : 1.4'])
assert_canonical([':'], [':,1.3, 1.3.1,1.3.9,1.4 : 1.5 , 1.3 : 1.4'])
[docs]def test_intersection():
check_intersection('2.5', '1.0:2.5', '2.5:3.0')
check_intersection('2.5:2.7', '1.0:2.7', '2.5:3.0')
check_intersection('0:1', ':', '0:1')
check_intersection(['1.0', '2.5:2.7'], ['1.0:2.7'], ['2.5:3.0', '1.0'])
check_intersection(['2.5:2.7'], ['1.1:2.7'], ['2.5:3.0', '1.0'])
check_intersection(['0:1'], [':'], ['0:1'])
[docs]def test_intersect_with_containment():
check_intersection('1.6.5', '1.6.5', ':1.6')
check_intersection('1.6.5', ':1.6', '1.6.5')
check_intersection('1.6:1.6.5', ':1.6.5', '1.6')
check_intersection('1.6:1.6.5', '1.6', ':1.6.5')
check_intersection('11.2', '11', '11.2')
check_intersection('11.2', '11.2', '11')
[docs]def test_union_with_containment():
check_union(':1.6', '1.6.5', ':1.6')
check_union(':1.6', ':1.6', '1.6.5')
check_union(':1.6', ':1.6.5', '1.6')
check_union(':1.6', '1.6', ':1.6.5')
check_union(':', '1.0:', ':2.0')
check_union('1:4', '1:3', '2:4')
check_union('1:4', '2:4', '1:3')
# Tests successor/predecessor case.
check_union('1:4', '1:2', '3:4')
[docs]def test_basic_version_satisfaction():
assert_satisfies('4.7.3', '4.7.3')
assert_satisfies('4.7.3', '4.7')
assert_satisfies('4.7.3b2', '4.7')
assert_satisfies('4.7b6', '4.7')
assert_satisfies('4.7.3', '4')
assert_satisfies('4.7.3b2', '4')
assert_satisfies('4.7b6', '4')
assert_does_not_satisfy('4.8.0', '4.9')
assert_does_not_satisfy('4.8', '4.9')
assert_does_not_satisfy('4', '4.9')
[docs]def test_basic_version_satisfaction_in_lists():
assert_satisfies(['4.7.3'], ['4.7.3'])
assert_satisfies(['4.7.3'], ['4.7'])
assert_satisfies(['4.7.3b2'], ['4.7'])
assert_satisfies(['4.7b6'], ['4.7'])
assert_satisfies(['4.7.3'], ['4'])
assert_satisfies(['4.7.3b2'], ['4'])
assert_satisfies(['4.7b6'], ['4'])
assert_does_not_satisfy(['4.8.0'], ['4.9'])
assert_does_not_satisfy(['4.8'], ['4.9'])
assert_does_not_satisfy(['4'], ['4.9'])
[docs]def test_version_range_satisfaction():
assert_satisfies('4.7b6', '4.3:4.7')
assert_satisfies('4.3.0', '4.3:4.7')
assert_satisfies('4.3.2', '4.3:4.7')
assert_does_not_satisfy('4.8.0', '4.3:4.7')
assert_does_not_satisfy('4.3', '4.4:4.7')
assert_satisfies('4.7b6', '4.3:4.7')
assert_does_not_satisfy('4.8.0', '4.3:4.7')
[docs]def test_version_range_satisfaction_in_lists():
assert_satisfies(['4.7b6'], ['4.3:4.7'])
assert_satisfies(['4.3.0'], ['4.3:4.7'])
assert_satisfies(['4.3.2'], ['4.3:4.7'])
assert_does_not_satisfy(['4.8.0'], ['4.3:4.7'])
assert_does_not_satisfy(['4.3'], ['4.4:4.7'])
assert_satisfies(['4.7b6'], ['4.3:4.7'])
assert_does_not_satisfy(['4.8.0'], ['4.3:4.7'])
[docs]def test_satisfaction_with_lists():
assert_satisfies('4.7', '4.3, 4.6, 4.7')
assert_satisfies('4.7.3', '4.3, 4.6, 4.7')
assert_satisfies('4.6.5', '4.3, 4.6, 4.7')
assert_satisfies('4.6.5.2', '4.3, 4.6, 4.7')
assert_does_not_satisfy('4', '4.3, 4.6, 4.7')
assert_does_not_satisfy('4.8.0', '4.2, 4.3:4.7')
assert_satisfies('4.8.0', '4.2, 4.3:4.8')
assert_satisfies('4.8.2', '4.2, 4.3:4.8')
[docs]def test_up_to():
v = Version('1.23-4_5b')
assert v.up_to(1).string == '1'
assert v.up_to(2).string == '1.23'
assert v.up_to(3).string == '1.23-4'
assert v.up_to(4).string == '1.23-4_5'
assert v.up_to(5).string == '1.23-4_5b'
assert v.up_to(-1).string == '1.23-4_5'
assert v.up_to(-2).string == '1.23-4'
assert v.up_to(-3).string == '1.23'
assert v.up_to(-4).string == '1'
assert v.up_to(2).dotted.string == '1.23'
assert v.up_to(2).dashed.string == '1-23'
assert v.up_to(2).underscored.string == '1_23'
assert v.up_to(2).joined.string == '123'
assert v.dotted.up_to(2).string == '1.23' == v.up_to(2).dotted.string
assert v.dashed.up_to(2).string == '1-23' == v.up_to(2).dashed.string
assert v.underscored.up_to(2).string == '1_23'
assert v.up_to(2).underscored.string == '1_23'
assert v.up_to(2).up_to(1).string == '1'
[docs]def test_repr_and_str():
def check_repr_and_str(vrs):
a = Version(vrs)
assert repr(a) == "Version('" + vrs + "')"
b = eval(repr(a))
assert a == b
assert str(a) == vrs
assert str(a) == str(b)
check_repr_and_str('1.2.3')
check_repr_and_str('R2016a')
check_repr_and_str('R2016a.2-3_4')
[docs]def test_len():
a = Version('1.2.3.4')
assert len(a) == len(a.version)
assert(len(a) == 4)
b = Version('2018.0')
assert(len(b) == 2)
[docs]def test_get_item():
a = Version('0.1_2-3')
assert isinstance(a[1], int)
# Test slicing
b = a[0:2]
assert isinstance(b, Version)
assert b == Version('0.1')
assert repr(b) == "Version('0.1')"
assert str(b) == '0.1'
b = a[0:3]
assert isinstance(b, Version)
assert b == Version('0.1_2')
assert repr(b) == "Version('0.1_2')"
assert str(b) == '0.1_2'
b = a[1:]
assert isinstance(b, Version)
assert b == Version('1_2-3')
assert repr(b) == "Version('1_2-3')"
assert str(b) == '1_2-3'
# Raise TypeError on tuples
with pytest.raises(TypeError):
b.__getitem__(1, 2)
[docs]def test_list_highest():
vl = VersionList(['master', '1.2.3', 'develop', '3.4.5', 'foobar'])
assert vl.highest() == Version('develop')
assert vl.lowest() == Version('foobar')
assert vl.highest_numeric() == Version('3.4.5')
vl2 = VersionList(['master', 'develop'])
assert vl2.highest_numeric() is None
assert vl2.preferred() == Version('develop')
assert vl2.lowest() == Version('master')
[docs]@pytest.mark.parametrize('version_str', [
"foo 1.2.0",
"!",
"1!2"
])
def test_invalid_versions(version_str):
"""Ensure invalid versions are rejected with a ValueError"""
with pytest.raises(ValueError):
Version(version_str)
[docs]@pytest.mark.skipif(sys.platform == 'win32',
reason="Not supported on Windows (yet)")
def test_versions_from_git(mock_git_version_info, monkeypatch, mock_packages):
repo_path, filename, commits = mock_git_version_info
monkeypatch.setattr(spack.package.PackageBase, 'git', 'file://%s' % repo_path,
raising=False)
for commit in commits:
spec = spack.spec.Spec('git-test-commit@%s' % commit)
version = spec.version
comparator = [str(v) if not isinstance(v, int) else v
for v in version._cmp(version.commit_lookup)]
with working_dir(repo_path):
which('git')('checkout', commit)
with open(os.path.join(repo_path, filename), 'r') as f:
expected = f.read()
assert str(comparator) == expected
[docs]@pytest.mark.skipif(sys.platform == 'win32',
reason="Not supported on Windows (yet)")
def test_git_hash_comparisons(
mock_git_version_info, install_mockery, mock_packages, monkeypatch):
"""Check that hashes compare properly to versions
"""
repo_path, filename, commits = mock_git_version_info
monkeypatch.setattr(spack.package.PackageBase,
'git', 'file://%s' % repo_path,
raising=False)
# Spec based on earliest commit
spec0 = spack.spec.Spec('git-test-commit@%s' % commits[-1])
spec0.concretize()
assert spec0.satisfies('@:0')
assert not spec0.satisfies('@1.0')
# Spec based on second commit (same as version 1.0)
spec1 = spack.spec.Spec('git-test-commit@%s' % commits[-2])
spec1.concretize()
assert spec1.satisfies('@1.0')
assert not spec1.satisfies('@1.1:')
# Spec based on 4th commit (in timestamp order)
spec4 = spack.spec.Spec('git-test-commit@%s' % commits[-4])
spec4.concretize()
assert spec4.satisfies('@1.1')
assert spec4.satisfies('@1.0:1.2')
[docs]def test_version_range_nonempty():
assert Version('1.2.9') in VersionRange('1.2.0', '1.2')
assert Version('1.1.1') in ver('1.0:1')
[docs]def test_empty_version_range_raises():
with pytest.raises(ValueError):
assert VersionRange('2', '1.0')
with pytest.raises(ValueError):
assert ver('2:1.0')
[docs]def test_version_empty_slice():
"""Check an empty slice to confirm get "empty" version instead of
an IndexError (#25953).
"""
assert Version('1.')[1:] == Version('')
[docs]def test_version_wrong_idx_type():
"""Ensure exception raised if attempt to use non-integer index."""
v = Version('1.1')
with pytest.raises(TypeError):
v['0:']
[docs]@pytest.mark.regression('29170')
def test_version_range_satisfies_means_nonempty_intersection():
x = VersionRange('3.7.0', '3')
y = VersionRange('3.6.0', '3.6.0')
assert not x.satisfies(y)
assert not y.satisfies(x)
[docs]@pytest.mark.regression('26482')
def test_version_list_with_range_included_in_concrete_version_interpreted_as_range():
# Note: this test only tests whether we can construct a version list of a range
# and a version, where the range is contained in the version when it is interpreted
# as a range. That is: Version('3.1') interpreted as VersionRange('3.1', '3.1').
# Cleary it *shouldn't* be interpreted that way, but that is how Spack currently
# behaves, and this test only ensures that creating a VersionList of this type
# does not throw like reported in the linked Github issue.
VersionList([Version('3.1'), VersionRange('3.1.1', '3.1.2')])
[docs]@pytest.mark.xfail
def test_version_list_with_range_and_concrete_version_is_not_concrete():
v = VersionList([Version('3.1'), VersionRange('3.1.1', '3.1.2')])
assert v.concrete